keda icon indicating copy to clipboard operation
keda copied to clipboard

fix: issue when GitHub organization contains more than 30 repos

Open KoblerS opened this issue 4 months ago • 6 comments

Fixed issue when GitHub organization contains more than 30 repositories. Scaler will now iterate over the pages according to GitHubs documentation.

Checklist

  • [x] When introducing a new scaler, I agree with the scaling governance policy
  • [x] I have verified that my change is according to the deprecations & breaking changes policy
  • [x] Tests have been added
  • [x] Changelog has been updated and is aligned with our changelog requirements
  • [x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [x] A PR is opened to update the documentation on (repo) (if applicable)
  • [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

  • https://github.com/kedacore/keda/issues/5738

KoblerS avatar Apr 25 '24 11:04 KoblerS

@JorTurFer sure will work on it!

KoblerS avatar Apr 28 '24 10:04 KoblerS

@KoblerS could you please fix the DCO problem?

could you please check again. Thanks!

KoblerS avatar May 17 '24 09:05 KoblerS

Semgrep found 1 context-todo finding:

  • pkg/scalers/github_runner_scaler_test.go

Consider to use well-defined context

Ignore this finding from context-todo.

semgrep-app[bot] avatar May 17 '24 09:05 semgrep-app[bot]

@KoblerS you can see the failed static check output: https://github.com/kedacore/keda/actions/runs/9127598269/job/25098204457?pr=5746

zroubalik avatar May 17 '24 11:05 zroubalik

@KoblerS you can see the failed static check output: https://github.com/kedacore/keda/actions/runs/9127598269/job/25098204457?pr=5746

sorry didn't saw it, should be fixed now.

KoblerS avatar May 17 '24 11:05 KoblerS

/run-e2e github Update: You can check the progress here

zroubalik avatar May 17 '24 12:05 zroubalik

/run-e2e github Update: You can check the progress here

Any updates when this will be merged?

KoblerS avatar May 20 '24 09:05 KoblerS