keda icon indicating copy to clipboard operation
keda copied to clipboard

GitHub-Runner scaler discovering only first repo list page

Open KoblerS opened this issue 4 months ago • 0 comments

Report

The GitHub runner scaler only discovers repositories on the first page of the "list-repositories" rest api request. Especially if a organisation exceeds the limit for the first page, see GitHub API reference: https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-organization-repositories

Per default GitHub only returns first 30 repositories and further repos need to be paginated.

Expected Behavior

It should discover all repos in the organisation by paginating through.

Actual Behavior

Right now only first 30 repositories are retrieved and if the the corresponding repository is on the second or third page then KEDA will not scale up

Steps to Reproduce the Problem

  1. Create a bunch of repositories in the organization > 30
  2. Make sure that the corresponding repo that should be builded is not the first page in the rest API
  3. KEDA will not scale based on this repository

Logs from KEDA operator

No response

KEDA Version

2.12.1

Kubernetes Version

None

Platform

Microsoft Azure

Scaler Details

Azure Container App Job

Anything else?

No response

KoblerS avatar Apr 24 '24 13:04 KoblerS