keda icon indicating copy to clipboard operation
keda copied to clipboard

Added some unit tests for the scaledjob_controller.go

Open geoffrey1330 opened this issue 1 year ago • 3 comments

Signed-off-by: geoffrey1330 [email protected]

Provide a description of what has been changed

Checklist

  • [ ] When introducing a new scaler, I agree with the scaling governance policy
  • [x] I have verified that my change is according to the deprecations & breaking changes policy
  • [x] Tests have been added
  • [ ] Changelog has been updated and is aligned with our changelog requirements
  • [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [ ] A PR is opened to update the documentation on (repo) (if applicable)
  • [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #3661

Relates to #2357

geoffrey1330 avatar Feb 12 '24 13:02 geoffrey1330

The new test is failing with with error: [FAILED] Expected jobs to be created

JorTurFer avatar Feb 16 '24 11:02 JorTurFer

@geoffrey1330 Any update on this PR?

tomkerkhove avatar Apr 24 '24 08:04 tomkerkhove

@geoffrey1330 Any update on this PR?

Nothing yet.

geoffrey1330 avatar Apr 25 '24 18:04 geoffrey1330

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 25 '24 00:06 stale[bot]

This issue has been automatically closed due to inactivity.

stale[bot] avatar Jul 02 '24 06:07 stale[bot]