keda icon indicating copy to clipboard operation
keda copied to clipboard

`make deploy` shouldn't enable opentelemetry by default

Open zroubalik opened this issue 1 year ago • 2 comments

Proposal

make deploy is usually used for development purposes of KEDA. With some recent changes, if one run this command, KEDA is configured to enable opentelemery collector.

We should revisit this approach and don't enforce opentelemetry usage. make deploy is also used to run e2e tests in our infra - there is enabling the opentelemetry collector expected. https://github.com/kedacore/keda/blob/5648b5702ae30fa295f231eb1684f2f5f37127f6/tests/utils/setup_test.go#L220

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response

zroubalik avatar Jan 15 '24 10:01 zroubalik

I think we can add a flag like AZURE_RUN_AAD_POD_IDENTITY_TESTS to enable/disable opentelemetry.

SpiritZhou avatar Jan 16 '24 06:01 SpiritZhou

I think more generic flag like ENABLE_OPENTELEMETRY might be better. I am okay with enabling OTEL for all e2e tests in CI, but would like to disable this by default for local development with make deploy.

zroubalik avatar Jan 16 '24 10:01 zroubalik