change stripDeadJobs to ReservedAgent

[ramondegoede]

Change the function in which the scaler looks for jobs to filter out from succeeded to reserved agent. This makes will make the filtering of jobs which have been taken over even quicker, because jobs which are running but not succeeded yet will also be filtered out.

Checklist

• [ ] When introducing a new scaler, I agree with the scaling governance policy
• [ ] I have verified that my change is according to the deprecations & breaking changes policy
• [ ] Tests have been added
• [ ] Changelog has been updated and is aligned with our changelog requirements
• [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• [ ] A PR is opened to update the documentation on (repo) (if applicable)
• [ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

[ramondegoede]

/run-e2e

[github-actions[bot]]

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

• Add an entry in our changelog in alphabetical order and link related issue
• Update the documentation, if needed
• Add unit & e2e tests for your changes
• GitHub checks are passing
• Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

• Our contribution guide

[JorTurFer]

/run-e2e pipeline Update: You can check the progress here

[JorTurFer]

@Eldarrin , WDYT about this change?

[Eldarrin]

damn, written and deleted a response twice. I see it now, but does it really matter as the system is working and the change will at most affect microseconds? But yeah, could be an improvement if it was tested thoroughly at scale

[JorTurFer]

I'm worried about it because I have executed e2e tests twice and both times azure_pipelines_test has failed. Could you check it @ramondegoede ?

[JorTurFer]

/run-e2e pipeline Update: You can check the progress here

[Eldarrin]

I'm worried about it because I have executed e2e tests twice and both times azure_pipelines_test has failed. Could you check it @ramondegoede ?

quick check pat tokens didn't expire? :) can't see results. But don't see a reason to make the change tbh

@ramondegoede if you were unaware, jobrequests is an unreleased API from MS; so we need to be very careful as its not on any review/maintain cycle. And we haven't found a better alternative

[JorTurFer]

quick check pat tokens didn't expire?

I don't think so. The other AzPipeline e2e test passes: https://github.com/kedacore/keda/actions/runs/6513120951/job/17694623703#step:9:1840

EXECUTION SUMMARY
##############################################
##############################################
Passed tests:
	Execution of tests/scalers/azure/azure_pipelines_adv/azure_pipelines_adv_test.go, has passed after "one" attempts
Failed tests:
	Execution of tests/scalers/azure/azure_pipelines/azure_pipelines_test.go, has failed after "three" attempts

Also, nightly build passes, so it's not something related with the e2e test case: https://github.com/kedacore/keda/actions/runs/6514260924

[Eldarrin]

So, not for merging IMHO

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically closed due to inactivity.