keda icon indicating copy to clipboard operation
keda copied to clipboard

e2e: Make order of applying / deleting templates consistent.

Open v-shenoy opened this issue 2 years ago • 8 comments

Signed-off-by: Vighnesh Shenoy [email protected]

Earlier, the apply / delete functions for Kubernetes templates were using maps. Iteration order is not guaranteed for maps in Go. So, which template would get applied / deleted first would be run dependent. This matters in cases where one template is dependent on other (ex - SO depends on target deployment). This leads to noise in the KEDA pod logs with errors that are unrelated to test failures themselves.

Sorry for the large PR.

Checklist

  • [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [x] Tests have been added

v-shenoy avatar Aug 09 '22 18:08 v-shenoy

/run-e2e Update: You can check the progress here

v-shenoy avatar Aug 09 '22 18:08 v-shenoy

/run-e2e solace* Update: You can check the progress here

JorTurFer avatar Aug 09 '22 21:08 JorTurFer

Thanks for the improvemnt!

JorTurFer avatar Aug 09 '22 21:08 JorTurFer

/run-e2e solace* Update: You can check the progress here

v-shenoy avatar Aug 10 '22 09:08 v-shenoy

Funny, the solace test seems to run fine on my dev cluster, pastebin. @JorTurFer

v-shenoy avatar Aug 10 '22 15:08 v-shenoy

Funny, the solace test seems to run fine on my dev cluster, pastebin. @JorTurFer

could we have any dangling resource in the cluster? I'm on vacations and I don't have my computer here to connect to the cluster

JorTurFer avatar Aug 10 '22 15:08 JorTurFer

Funny, the solace test seems to run fine on my dev cluster, pastebin. @JorTurFer

could we have any dangling resource in the cluster? I'm on vacations and I don't have my computer here to connect to the cluster

I am not sure @JorTurFer

v-shenoy avatar Aug 10 '22 18:08 v-shenoy

Could you take a look please @tomkerkhove ?:pray:

JorTurFer avatar Aug 10 '22 19:08 JorTurFer

/run-e2e solace* Update: You can check the progress here

zroubalik avatar Aug 14 '22 17:08 zroubalik