keda-olm-operator icon indicating copy to clipboard operation
keda-olm-operator copied to clipboard

Change the way resources yaml file is being loaded

Open zroubalik opened this issue 4 years ago • 4 comments

At the moment the resources file is being loaded into the operator during the startup: https://github.com/kedacore/keda-olm-operator/blob/cbd80d4af6e95d5f0ad36af6631d3a8a008c5e3e/controllers/keda/kedacontroller_controller.go#L76-L83

It would be better to use go embed feature introduced in Go 1.16: https://golangtutorial.dev/tips/embed-files-in-go/

zroubalik avatar Aug 25 '21 08:08 zroubalik

Hi @zroubalik, Can I work on this?

husnialhamdani avatar Oct 06 '23 16:10 husnialhamdani

@husnialhamdani absolutely, please coordinate with @joelsmith, he is the main point of contact for this repo.

zroubalik avatar Oct 06 '23 18:10 zroubalik

@husnialhamdani, that would be great, thanks! Let me know if you have any questions along the way

joelsmith avatar Oct 07 '23 21:10 joelsmith

@joelsmith @zroubalik Thanks for assigning, want to confirm if my understanding correct, So we have to change the way to load the resources with Go embed in this file ?

husnialhamdani avatar Oct 13 '23 12:10 husnialhamdani