keda-docs icon indicating copy to clipboard operation
keda-docs copied to clipboard

Added datadogMetricsService and fix datadogNamespace key in triggerAu…

Open alvarobacelar opened this issue 1 year ago • 6 comments
trafficstars

Included datadogMetricsService and fixed datadogNamespace key in triggerAuthenticatio specs. When I have been Tried this configurations I got errors. After I fix this keys, provide in this PR, works well.

Checklist

  • [x] Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

alvarobacelar avatar Sep 17 '24 18:09 alvarobacelar

Deploy Preview for keda ready!

Name Link
Latest commit b9b49f094ed8a78c750ed78e4a3805874b26b740
Latest deploy log https://app.netlify.com/sites/keda/deploys/671c1609b1f4ac000838bc62
Deploy Preview https://deploy-preview-1469--keda.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 17 '24 18:09 netlify[bot]

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

github-actions[bot] avatar Sep 17 '24 18:09 github-actions[bot]

Thanks, duplicate of: https://github.com/kedacore/keda-docs/pull/1451/

zroubalik avatar Sep 18 '24 11:09 zroubalik

Hello @zroubalik , but this PR fix the namespace as well.

https://github.com/kedacore/keda-docs/pull/1469/files#diff-015e70f7405a2745734c1d02b964c2a3990ff85783e2bbf9f31a12037c115552R144

alvarobacelar avatar Sep 18 '24 16:09 alvarobacelar

@alvarobacelar thanks, haven't notice that. Could you please rebase this PR ?

zroubalik avatar Sep 18 '24 19:09 zroubalik

@zroubalik I've been done.

alvarobacelar avatar Sep 19 '24 16:09 alvarobacelar

Hi @zroubalik. is it everything ok with this PR?

alvarobacelar avatar Oct 04 '24 15:10 alvarobacelar

Hello, @JorTurFer. I think this PR it's ok. Could you please review it?

alvarobacelar avatar Oct 11 '24 20:10 alvarobacelar

@zroubalik what happened with this PR? Is there something wrong? Please let me know if there’s anything wrong.

alvarobacelar avatar Oct 25 '24 22:10 alvarobacelar