keda-docs icon indicating copy to clipboard operation
keda-docs copied to clipboard

Fix Cloudwatch documentation suggesting invalid conditions

Open nicolajv opened this issue 1 year ago • 2 comments

Provide a description of what has been changed

The currently documentation incorrectly assumes the ability to scope down KEDA GetMetricData permissions by the use of conditions. However as shown in the official Actions defined by Amazon CloudWatch documentation, GetMetricData does not support any condition keys.

Checklist

  • [x] Commits are signed with Developer Certificate of Origin (DCO)

nicolajv avatar Aug 30 '24 11:08 nicolajv

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

github-actions[bot] avatar Aug 30 '24 11:08 github-actions[bot]

Deploy Preview for keda ready!

Name Link
Latest commit 3c902f3ac4239dec0bfe2399d2f649ea9819b5b9
Latest deploy log https://app.netlify.com/sites/keda/deploys/672874e4ee01dc0008b9a885
Deploy Preview https://deploy-preview-1462--keda.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 30 '24 11:08 netlify[bot]

This is correct, and my mistake, putmetricdata has a condition, not getmetricdata

robpickerill avatar Nov 06 '24 06:11 robpickerill