keda-docs icon indicating copy to clipboard operation
keda-docs copied to clipboard

Remove unused variables and correct queueDepth default in IBM MQ scaler

Open rickbrouwer opened this issue 1 year ago • 2 comments

  • The current documentation states that the default queueDepth is 5, while the code default is 20. The documentation will be updated to reflect the correct default value of 20, aligning it with the code.
  • The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code is removed. The documentation is updated accordingly.
  • The parameter tlsDisabled is removed. All other scalers use the parameter unsafeSsl. To maintain consistency across the other scalers, the code related to tlsDisabled is removed, as unsafeSsl already handles this functionality.
  • Finally, some minor adjustments to the documentation to keep the formatting the same.

Checklist

  • [X] Commits are signed with Developer Certificate of Origin (DCO)

Fixes #6033

rickbrouwer avatar Aug 05 '24 10:08 rickbrouwer

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

github-actions[bot] avatar Aug 05 '24 10:08 github-actions[bot]

Deploy Preview for keda ready!

Name Link
Latest commit 1b5436999a2f71950d30c1aecc06096c41e7aedf
Latest deploy log https://app.netlify.com/sites/keda/deploys/66c4571e32a8bc000839c595
Deploy Preview https://deploy-preview-1445--keda.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 05 '24 10:08 netlify[bot]

Are all deprecated? image

I thought that only the tls one is deprecated

JorTurFer avatar Aug 19 '24 19:08 JorTurFer

Are all deprecated? image

I thought that only the tls one is deprecated

Yes, sorry. My bad. I misunderstood something. I have changed it back.

rickbrouwer avatar Aug 20 '24 08:08 rickbrouwer