http-add-on icon indicating copy to clipboard operation
http-add-on copied to clipboard

Use the external push gRPC protocol for external scaler => interceptor communication

Open arschles opened this issue 4 years ago • 14 comments

We currently use a simple HTTP/JSON protocol for the scaler to communicate with the interceptor. Because this protocol is just request/response, it has limitations on latency that can cause very slow scale up times, which are especially noticeable when scaling up from 0 replicas.

It would be helpful to have some kind of two way protocol rather than what we have now. The external push scaler provides just this. We should take this and use it in the scaler.

Use-Case

As mentioned above, this would be useful to speed up scale-up (and down) latencies. This may help with #60 as well, but that's not the primary goal here.

Specification

arschles avatar Mar 15 '21 18:03 arschles

Is there any plan to implement the external push interface?

benjaminhuo avatar Aug 12 '21 01:08 benjaminhuo

@benjaminhuo we would likely implement the external push interface or something similar but simpler (because my guess is we won't need all the complexity of the current external push interface)

arschles avatar Aug 16 '21 20:08 arschles

Looking forward to seeing this added!

benjaminhuo avatar Aug 17 '21 02:08 benjaminhuo

Same here @benjaminhuo. @ajanth97 and I are going to come up with a design in the near future and the current plan is he's going to implement it. This will probably all start in earnest after the big #206 is merged.

Let me know if you'd like to get involved - you're certainly welcome to!

arschles avatar Aug 18 '21 17:08 arschles

@arschles Yes sure, I'm happy to get involved!

benjaminhuo avatar Aug 19 '21 01:08 benjaminhuo

ok. let's start by collaborating on a design. I've started a document here. feel free to leave comments etc...

Note: If you haven't used hackmd before, you have to login with your GitHub (or it supports some other SSO types I think) account before you can edit or comment.

arschles avatar Aug 19 '21 17:08 arschles

Awesome

ajanth97 avatar Aug 19 '21 17:08 ajanth97

ok. let's start by collaborating on a design. I've started a document here. feel free to leave comments etc...

Note: If you haven't used hackmd before, you have to login with your GitHub (or it supports some other SSO types I think) account before you can edit or comment.

@arschles That's a great place to start! @tpiperatgod @wanjunlei you can also take a look at this doc https://hackmd.io/ttpSY5KQQtGIqbAzyKex3g if you're interested

benjaminhuo avatar Aug 20 '21 02:08 benjaminhuo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 19 '21 03:10 stale[bot]

This is ongoing. @ajanth97 is working on it

arschles avatar Oct 19 '21 19:10 arschles

Any update on this? Is it still relevant?

tomkerkhove avatar May 11 '22 12:05 tomkerkhove

Hi Sorry, I will work on this soon

ajanth97 avatar May 11 '22 14:05 ajanth97

Great, thanks!

tomkerkhove avatar May 11 '22 14:05 tomkerkhove

Is it still relevant?

FWIW, I think it still is 😄

arschles avatar May 13 '22 15:05 arschles