charts icon indicating copy to clipboard operation
charts copied to clipboard

Adding RBAC namespace selection for metrics server

Open Rotzke opened this issue 1 year ago • 4 comments

Provide a description of what has been changed

Checklist

  • [x] I have verified that my change is according to the deprecations & breaking changes policy
  • [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [x] README is updated with new configuration values (if applicable) learn more
  • [x] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #645

Rotzke avatar Aug 05 '24 13:08 Rotzke

Hi @JorTurFer ! I have made a duplicate of https://github.com/kedacore/charts/pull/657 because it is stuck since the 28. of June and I was actually the one who requested the feature, please review my MR, I excluded version changes as you requested in the initial MR.

Rotzke avatar Aug 05 '24 13:08 Rotzke

To make users 100% aware of the goal, we could call the parameter like controlPlaneServiceAccountsNamespace. I know that there are docs where it's explained how to enable the control plane permission segregation that spread the permissions in multiple service account, but I can't find it (it's a control plane argument). If you find it, I think that it's a good idea adding the link

JorTurFer avatar Sep 02 '24 21:09 JorTurFer

To make users 100% aware of the goal, we could call the parameter like controlPlaneServiceAccountsNamespace. I know that there are docs where it's explained how to enable the control plane permission segregation that spread the permissions in multiple service account, but I can't find it (it's a control plane argument). If you find it, I think that it's a good idea adding the link

@JorTurFer I have renamed the variables, haven't really found those docs you mentioned, though it is not a command line argument for any of control plane components, I guess. Can we still get this merged into the next release/minor/patch version? Would be really cool, we are shivering in anticipation, waited for some time. Thanks in advance!

Rotzke avatar Sep 03 '24 08:09 Rotzke

Can we still get this merged into the next release/minor/patch version?

Yeah! just let me look for the link a few days more and definitively this will be included for next version

JorTurFer avatar Sep 03 '24 11:09 JorTurFer