charts icon indicating copy to clipboard operation
charts copied to clipboard

Add vpa crs for keda-operator and metrics-server

Open QuantumEnigmaa opened this issue 2 years ago • 5 comments
trafficstars

This PR adds VPA CRs for both keda-operator and metrics-server.

Checklist

  • [x] I have verified that my change is according to the deprecations & breaking changes policy
  • [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [x] README is updated with new configuration values (if applicable) learn more
  • [ ] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #

QuantumEnigmaa avatar Nov 09 '23 08:11 QuantumEnigmaa

I just noticed I forgot to sign my 2 previous commits :/

QuantumEnigmaa avatar Nov 09 '23 11:11 QuantumEnigmaa

@tomkerkhove I reverted the changes on the artefacts

QuantumEnigmaa avatar Nov 14 '23 12:11 QuantumEnigmaa

I think that this is fascinating, but I'm not sure if it works correctly before the live pod resizing is in GA. I mean, restarting the operator for updating the pod size could produce scaling downtimes and we should clarify it IMHO. This also could generate impact on k8s api server on huge clusters if the VPA scales the pod so often because all the scalers cache has to be rebuilt on each restart, recovering all the needed info from the cluster

JorTurFer avatar Nov 20 '23 23:11 JorTurFer