Improve the consistency in KEDA chart

[JorTurFer]

trafficstars

Working with KEDA chart, I found that it hasn't got consistency in the names when it refers to each application, for example, sometimes the operator is named keda and other times is named operator. With metrics server happens the same, sometimes is called as metricsApiServer, metricServer, metricsServer, metricsAdapter.

This is a breaking change, but maybe it could be in the next major release, and it reduces the complexity of the chart. IDK, maybe the chart values could be something like:

operator:
  resources: {}
  tag: {}
  logging: {}
  # .....
metricsServer:
  resources: {}
  tag: {}
  logging: {}

IMHO, at least the naming should be unified to reduce the general complexity Wdyt?

[tomkerkhove]

Good feedback, adding it to milestone for when we plan a new major version!

[tomkerkhove]

Until then, we can change it so that it's done in a non-breaking manner but it can be quite messy so not sure if it's worth the time

[JorTurFer]

Probably it's better if we wait until 2-3 weeks before the major release because in other case 2 charts would have to be maintained :/

[JorTurFer]

During the context of this task, who will do it have to take in consideration that the resources are pending to split. They'd have been split here in the context of https://github.com/kedacore/charts/issues/182, but we decided to wait until this task to avoid one breaking change

[AshutoshNirkhe]

This will indeed be a nice update!

[JorTurFer]

I think that it's the moment to address this issue. I created it almost 2 years ago and we still don't plan a major KEDA release. As we have recently introduced the "big changes" in the architecture and we don't plan to introduce new big changes soon, I'd prepare the v3 of the chart, refactoring the whole chart, solving all the gaps and duplications that we currently have.

Currently, we have a chaotic chart with a lot of parameters without any sense (at least for me) WDYT @kedacore/keda-helm-contributors ?

[tomkerkhove]

Feel free to do so, I don't have a preference. However, if we do then we should be very thorough.