Percy Ma

Results 75 comments of Percy Ma

I'm concerned that when people make changes to existing files, the PRs submitted will have a lot of extraneous diffs that will affect the review.

I like the third button. It does seem more common too.

Should it also be allowed to opt-in in `eslint.config.js`?

In view of the current situation that the related RFC is about to be merged, I think this PR will also be active, so it should not be regarded as...

I improved the coverage and both of the ones you mentioned have been resolved. But please let me know if there are other cases that are not covered

> I think the option name should be something like `ternaryOperandBinaryExpressions` or `binaryExpressionsAsTernaryOperands`. My confusion is that the option allows not only `BinaryExpressions` but also `LogicalExpression`. But there is only...

I think it makes sense and is low cost to support this in a runtime that supports ts natively. Like deno and bun, we can just import them.

This is consistent with what I mentioned in https://github.com/eslint/rfcs/pull/117#issuecomment-1987209637. We can check the runtime and import it directly, otherwise keep looking for the ts loader

importx looks good. But based on the discussion above we seem to prefer letting the user install the optional loader themselves.

Does it need to be automatic? Or should we mark it manually?