Kristian Duske
Kristian Duske
We often return NaN as a magic value to signal that no result could be computed. We should replace this with `std::optional` to make the code safer and easier to...
The API should be as compatible as possible to GLSL. This requires adding type and function name aliases and adding missing functions. See https://www.khronos.org/files/opengl-quick-reference-card.pdf - rename `compute_determinant` to `determinant` -...
`is_equal` for plane currently compares the plane's distance and normal using the same epsilon, but it should be comparing the distances and angle between the normals, and with different epsilon...
`vm::view_matrix` currently says > Returns a view transformation matrix which transforms normalized device coordinates to window coordinates. But this is wrong. It transforms from world space to view space. Likewise,...
When models are loaded, we build an AABB tree for picking, which can be quite slow for complex models. We should speed this up. Ideas: - precompute AABB tree using...
In https://github.com/TrenchBroom/TrenchBroom/commit/80b1fae65049f152a59ded59fbf8cc5eed981dbf we changed the behavior of the "copy files" compilation task so that a target directory is created if it doesn't exist. This change implies that the target path...
**Put opening braces in separate lines**. This makes it easier to distinguish indented function parameters and the body: ``` HandlePositionProposer start( const InputState& inputState, const vm::vec3&, const vm::vec3& handleOffset) override...
Find closest match with current values, if it already fits cycle through next matches