Kyle D.

> So, overall I think the DB would be better than a normal file. However, I'm not too experienced when dealing with large clusters, perhaps DevOps experts know some ways...

> > It is easier to dump the SQL result into a JSON file than it is the other way around. > > I still stand by that. So, it...

Gitea code-base has the concept of "official reviewer", but how it is counted is pretty inconsistent and confusing the UI. Before: - Any user with Pull Request "read" permissions can...

> I think this is by design. Maybe we need docs to explain it. What's the intended case for it?

> `Approve` means I think this PR is ok to be merged, this is `opinion`, and anyone can convey their opinions. But the approval count will finally affect `Merge`, and...

@yp05327 @wolfogre Thanks, I think we agree for the most part. To be clear: I only suggest one of those two options, not both. Both involve getting rid of "official...

> Why do we need to store the official reviewer in the database someone may not be an official reviewer anymore. He maybe leave one team to another team. But...

> Why a person can read the code could approve the code change? At least, it's impossible for open-source projects like Gitea. Also for those internal repositories shared with all...

> > Why a person can read the code could approve the code change? At least, it's impossible for open-source projects like Gitea. Also for those internal repositories shared with...

> `pull request read` is a permission to allow users to visit pull request and create pull request. So the official reviewer just ask `code writer` or `allowlist` of protected...