samsungctl icon indicating copy to clipboard operation
samsungctl copied to clipboard

Published 20 hours ago • verified publisher icon kdschlosser

I know there are going to be problems with the library.

Open kdschlosser opened this issue 6 years ago • 2 comments

I just dumped all of the UPNP stuff into the library. So we are going to work through one issue at a time. Please Please Please open a new issue for each bug you come across. This is extremely important. I want to make sure they all get fixed. check to make sure there is not an issue submitted already..

Also. If you have a fix for something do a PR for it. posting a code snippit in an issue makes it very difficult for me to assess if that snippit is going to work and not cause another issue. Having the pull request I get to see the fix along with the code surrounding it. I am going to try to make sure that i specify the persons name that found the bug in the merge.

If you have an issue relating to HomeAssistant. I am not going to answer you at all. I am concerned about getting the library to function properly without adding more complexity. So if i see the words HomeAssistant anywhere in an issue I will not respond. You have been told . So do not get mad at me. I can almost guarantee that any issue relating to HomeAssistant will go away once we get the library squared off.

I have not broken ANY of the previous API. it is all in tact.

This is a massive addition to the library. it almost triples the number of lines of code. I am only human and I know I have made some errors in it. If there isn't then I will probably fall out of my chair.

I am gong to address a single issue at a time. I am not going to jump from one to another. There will be no specific order in which I handle the problems. whatever my mouse lands on and clicks. I will move on once that problem is solved. If solving an issue causes another problem. PLEASE create a new issue for it. This process makes it a lot easier for me to see what is and is not fixed. If you add another issue into an already existing issue. I am going to ignore it.

kdschlosser avatar Jan 25 '19 23:01 kdschlosser

deal

matthieut59 avatar Jan 26 '19 10:01 matthieut59

I want to say TY thus for on the error reporting. I hope you can now see why i want it done this way. I am able to address and repair problems much much faster. and without any getting missed

kdschlosser avatar Jan 26 '19 20:01 kdschlosser