kdl icon indicating copy to clipboard operation
kdl copied to clipboard

Allow "empty" single line comments in the spec

Open basile-henry opened this issue 4 years ago • 2 comments

As I read the grammar in the spec, "//" wouldn't parse as a single-line-comment as it requires as least one non-newline character after the slashes.

basile-henry avatar Oct 11 '21 20:10 basile-henry

oof. Good catch. I'm moving this to the v2 branch, though, because it's a breaking change, and I wanna let others chime in in case anything else like this comes to mind.

zkat avatar Oct 12 '21 01:10 zkat

If it wouldn't parse successfully otherwise, it's not breaking, as it's solely extending the allowed grammar. I don't believe there's any case where // is valid currently, where it would potentially be a comment after this.

CAD97 avatar Nov 11 '21 01:11 CAD97