gridstack-angular icon indicating copy to clipboard operation
gridstack-angular copied to clipboard

Implement gridstack min/max item dimension

Open Zacaria opened this issue 9 years ago • 4 comments

Hi ! I found a big help in implementing your library.

I propose you to add better implementation of gridstack.js capabilities.

The new options for a widget are :

  • minWidth : applied with gs-item-min-width attribute
  • minHeight : applied with gs-item-min-height attribute
  • maxWidth : applied with gs-item-max-width attribute
  • maxHeight : applied with gs-item-max-height attribute

I let you generate the dist file :)

btw : it's my first PR so I don't know which information you would need

Zacaria avatar May 25 '16 15:05 Zacaria

Hi @Zacaria,

thank you for your PR. 👍 Could you please fix the indentations so that we can see better which lines have changed? See: https://github.com/kdietrich/gridstack-angular/pull/8/files Thanks!

kdietrich avatar May 27 '16 09:05 kdietrich

Would you please tell me the name of the linter/formatter you are using ?

Zacaria avatar May 27 '16 12:05 Zacaria

@Zacaria I've added jscs. Could you resubmit your PR? Thanks!

kdietrich avatar Aug 13 '16 11:08 kdietrich

Hi, @Zacaria @kdietrich

I think there is no need to watch the "data-gs-min-height", "data-gs-min-width", "data-gs-max-height", "data-gs-max-width" in gridstackitem.directive.js. These four properties can't be changed by user.

PS: It is still very hard to see the changed part because of the indentation...

siecj avatar Jun 30 '17 08:06 siecj