Dheepak Krishnamurthy

Results 442 comments of Dheepak Krishnamurthy

fwiw, I like the idea of putting the `assert_eq` in a trait: ``` trait AssertEq { fn assert_eq(&self, other: &Self); } impl AssertEq for Buffer { ...} ``` Maybe the...

I'd like for this change to be made because it'll make it consistent with a future feature like: https://github.com/ratatui-org/ratatui/issues/931

The `WidgetRef` and `StatefulWidgetRef` methods as well as new methods are being discussed in this issue: https://github.com/ratatui-org/ratatui/issues/996 Themes are discussed in this issue: https://github.com/ratatui-org/ratatui/issues/799 I just realized that I already...

For the average Ratatui user this change won't be breaking. For example, this code will remain unchanged: ```rust frame.render_widget( Paragraph::new("Example of a paragraph that a user writes") .alignment(Alignment::Center), area, );...

Another reason a `Context` would be useful is during render we can set the cursor at a specific location. Currently with `Buffer` cursors are handled separately. This will allow better...

I agree that this shouldn’t be done in haste. I think frame count is probably the strongest motivation for this right now.

We should probably update this function to handle styles as well: https://github.com/ratatui-org/ratatui/blob/326a461f9a345ba853d57afefc8d77ba0b0b5a14/src/backend/test.rs#L46-L73 And make the `TestBackend` configurable such that it either strips ansi styles or not when `Display` is invoked.

Yes absolutely! I'm happy to make it a PR in the future too (crediting you of course)!

In addition, I think layouts that are very common could use copy paste friendly docs on the website.

Related: https://github.com/ratatui-org/ratatui/issues/845, https://github.com/ratatui-org/ratatui/issues/1014