kdeme

at least at compile time, perhaps at runtime.

Only start sending messages when connected to > 1 peers?

2

Perhaps we should add a check of x connected peers before we start sending Whisper messages at the specified interval. If a node is only connected to 1 peer, and...

Devp2p `hello` packet passes the node its capabilities. Capability is a protocol short name + version. We should only start a sub-protocol (capability) between peers for the highest common version...

If we would have https://github.com/status-im/nim-eth/issues/140 working, we could get along by providing different Protocol names for different versions. E.g.: ```nim p2pProtocol Wakuv1(version = wakuVersion, ... p2pProtocol Wakuv2(version = differentWakuVersion, ......

I've seen the test_sparse_binary_trie test hanging sporadically on our CI tests. Specifically on Travis, MacOS AMD64. I can't recall, but it might also occur on Linux. ``` Running: tests/trie/test_sparse_binary_trie [Suite]...

Use the size of `short_rlp(envelope)` as length. As is done now in latest version of geth and Status whisper fork.

Limit (incoming) connecting peers.

2

Currently in our implementation, the maximum connected peers limit is only applied on the creation of new outgoing connections. The listener for incoming connections remains active. This gives a serious...

Might connect to more than allowed number of connections.

1

Currently the check of whether to try to connect to more peers happens before the call which tries to connect to an x amount of peers. A seq of candidate...

See also https://github.com/status-im/nim-eth/pull/71 Somewhat related to https://github.com/status-im/nim-eth/issues/63 Basically, the check/disconnect could also be moved to `dispatchMessages`. But then the peer will still briefly be added to the peer_pool. The disconnect...