click-extra icon indicating copy to clipboard operation
click-extra copied to clipboard

Set custom logger or overwrite verbosity option

Open MLNW opened this issue 2 years ago • 2 comments

Hey, I'm trying out your library mainly to add some colors to the help page and use the configuration file mechanism.

Before I used rich for logging and general printing purposes. Now with your library the logging configuration used is overwritten.

I was looking for a way to restore the old behavior but I didn't find a way to provide my own logging configuration.

Is there a way that I missed or if there is not could we add it?

MLNW avatar Jan 17 '22 19:01 MLNW

Thanks @MLNW for considering my little project! 😃

click-extra is currently in an acceptable MVP state and good enough for me that I can share it between my 2 main projects (meta-package-manager and mail-deduplicate). Which means there's actually some hard-coded stuff, low documentation and lots of coupling that can be annoying. And I guess you stumble upon that.

I was hoping to iron things out depending on external interest. You're my first user, so yeah, sorry for the trouble! 😅

Do you have an example on how you are actually using the help screen colouring and configuration file loading? Does that work? I can reuse your examples as a base to improve the documentation. I only took the time to properly document the --config parameter.

Now I was planning at one point to use rich myself for logging. Can you show me how you'd like to use click-extra with rich?

kdeldycke avatar Jan 17 '22 20:01 kdeldycke

So far I simply replaced the @click.group with the @group annotation from click-extra. That already colors the help screen and adds some additional options. Configuring these options seems impossible though, which is the main issue I am having.

Before I had some simple logging configuration like this:

    logging.basicConfig(
        format=log_format,
        datefmt=date_format,
        style="{",
        handlers=[RichHandler(rich_tracebacks=True)],
    )

Now all other commands in my module would simply use the same logging configuration when using import logging.

MLNW avatar Jan 18 '22 16:01 MLNW

Defaults logger are now better supported and documented at: https://kdeldycke.github.io/click-extra/logging.html

(See #174 for more discussion on the topic).

kdeldycke avatar Nov 11 '22 07:11 kdeldycke

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Feb 13 '23 08:02 github-actions[bot]