btrfsmaintenance icon indicating copy to clipboard operation
btrfsmaintenance copied to clipboard

two patches for btrfsmaintenance

Open ldzhong opened this issue 10 months ago • 4 comments

For the first patch, when this package was first installed, the timer will be scheduled as monthly for btrfs-balance.service. However if the user modifies configuration options other than BTRFS_BALANCE_PERIOD in /etc/sysconfig/btrfsmaintenance, the timer will be changed to weekly without being noticed. To avoid such a case, it's better to keep the value in the .timer file and the configuration file same. For the second patch, it tries to fix a timing window when editing the configuration file /etc/sysconfig/btrfsmaintenance. Please refer to the patch description for more detail.

ldzhong avatar Feb 06 '25 03:02 ldzhong

What's your motivation for the changes? What problems do they fix?

eku avatar Feb 06 '25 07:02 eku

What's your motivation for the changes? What problems do they fix?

I have updated the description for these two unrelated patches. Thanks for your reminding.

ldzhong avatar Feb 07 '25 00:02 ldzhong

If the patches are unrelated, they should probably be in separate pull requests. Note that movement is a little slow here. :-)

The text in your first commit could probably make it more obvious that the default timer values are incorrectly different - and that this is in fact a fix to align the values. As is, it reads that you are making an arbitrary decision when that is not true.

zatricky avatar Aug 16 '25 09:08 zatricky

Please split the changes to two patches (in one pull request).

kdave avatar Aug 18 '25 17:08 kdave