Kamil Cudnik
Kamil Cudnik
not sure how this is cauing RPC error, seems like your headers are not updated, in my change you pointed https://github.com/opencomputeproject/SAI/pull/2028/files#diff-444febffce442e4277a1ced22d1ab94df045dfaa10a1b671ee35a7e5c2d9f683R305 this line implements SAI_OBJECT_TYPE_EXTENSIONS_RANGE_BASE, SAI headers build is passing...
can i reporoduce this locally without building entire image ?
so seems like vendor headers needs to be updated, or we need to update rpc build to use local headers, since originally rpc build code is not my code, if...
problem is here: https://github.com/opencomputeproject/SAI/blob/master/test/saithrift/Makefile#L6 sai headers are taken form /usr/include/sai which are vendor headers, and experimental headers are taken from -I../../experimental as local headers to compile but im not sure...
> @kcudnik , I am able to build RPC image for BCM DNX if i change the sai-thrift Makefile to use the experimental header files from /usr/include/sai/experimental. Not sure if...
great, did you changed that in Makefile in SAI repo or in build process of this package in build image?
yea, but this will limit functionality, will be be able to change the code that is actually calling this Makefile? and pass SAI_HEADER_DIR=../../inc in command line ?
asked @saksarav-nokia whether he can make change in build https://github.com/sonic-net/sonic-buildimage/issues/20322#issuecomment-2402541011
its hard to say on other vendors, originally this code was added by mlnx
i proposes solution here: https://github.com/sonic-net/sonic-buildimage/issues/20322#issuecomment-2402541011