make initializer and terminator workspace URLs distinguishable
Summary
change adds a type field to the VirtualWorkspace api schema to make the initializer and terminator workspace URLs distinguishable.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes 3699
Release Notes
Adds a `type` field to the VirtualWorkspace API schema to distinguish between initializing and terminating workspace URLs.
/retest
Thanks for the contribution! This looks solid, would need to take an in-depth look, but I'll put a hold on it because we are very close to the 0.29.0 release and I wouldn't want to change APIs right now. After the release is out, we can merge this.
/hold
/retest
/retest
LGTM label has been added.
/retest
/lgtm /approve
LGTM label has been added.
/lgtm /approve
looks like @embik needs to unhold for merge to happen.
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mjudeikis, xmudrii
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mjudeikis,xmudrii]
- ~~config/crds/OWNERS~~ [mjudeikis]
- ~~staging/src/github.com/kcp-dev/sdk/apis/OWNERS~~ [mjudeikis]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest