kcp icon indicating copy to clipboard operation
kcp copied to clipboard

make initializer and terminator workspace URLs distinguishable

Open olamilekan000 opened this issue 3 months ago • 5 comments

Summary

change adds a type field to the VirtualWorkspace api schema to make the initializer and terminator workspace URLs distinguishable.
Screenshot 2025-11-08 at 02 01 25

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes 3699

Release Notes

Adds a `type` field to the VirtualWorkspace API schema to distinguish between initializing and terminating workspace URLs.

olamilekan000 avatar Nov 08 '25 01:11 olamilekan000

/retest

olamilekan000 avatar Nov 08 '25 07:11 olamilekan000

Thanks for the contribution! This looks solid, would need to take an in-depth look, but I'll put a hold on it because we are very close to the 0.29.0 release and I wouldn't want to change APIs right now. After the release is out, we can merge this.

/hold

embik avatar Nov 09 '25 16:11 embik

/retest

olamilekan000 avatar Nov 11 '25 23:11 olamilekan000

/retest

olamilekan000 avatar Nov 12 '25 15:11 olamilekan000

LGTM label has been added.

Git tree hash: 3138bd5119773648a747e30ab79784e62f1e686d

kcp-ci-bot avatar Dec 03 '25 13:12 kcp-ci-bot

/retest

olamilekan000 avatar Dec 04 '25 16:12 olamilekan000

/lgtm /approve

mjudeikis avatar Dec 09 '25 15:12 mjudeikis

LGTM label has been added.

Git tree hash: a1c52ff6e72a0e72cdd004d2b9c119406f17dfe4

kcp-ci-bot avatar Dec 09 '25 15:12 kcp-ci-bot

/lgtm /approve

looks like @embik needs to unhold for merge to happen.

olamilekan000 avatar Dec 09 '25 16:12 olamilekan000

/hold cancel

xmudrii avatar Dec 09 '25 16:12 xmudrii

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kcp-ci-bot avatar Dec 09 '25 16:12 kcp-ci-bot

/retest

olamilekan000 avatar Dec 09 '25 17:12 olamilekan000