kcp
kcp copied to clipboard
Extend `apis.kcp.io/v1alpha2` with `APIBinding`
Summary
This PR extends the apis.kcp.io/v1alpha2 with APIBindings and related types. This new version is a 1:1 copy of the current v1alpha1 API at the moment. The new v1alpha2 version will be changed after this PR is merged (to make this PR easier to review) as part of implementing #3255
All the code was updated to refer to v1alpha2.APIBindings.
https://github.com/kcp-dev/kcp/pull/3318 has been used as the inspiration for this PR.
What Type of PR Is This?
/kind feature
Related Issue(s)
None
Release Notes
Extended `apis.kcp.io/v1alpha2` with `APIBinding`
Sgtm.
While in general this looks good, the timing is questionable. Why don't we first get the API in place properly with the fields we want, and AFTER that do the "now everything will use it" PR ? Seems to be much more natural rather than having a limbo phase where the version is not ready, but already used.
While in general this looks good, the timing is questionable. Why don't we first get the API in place properly with the fields we want, and AFTER that do the "now everything will use it" PR ? Seems to be much more natural rather than having a limbo phase where the version is not ready, but already used.
I think the bot works IF we can get the next PR "chained to this PR " and merge them together. Would want to see "implementation" first before start merging.
While in general this looks good, the timing is questionable. Why don't we first get the API in place properly with the fields we want, and AFTER that do the "now everything will use it" PR ? Seems to be much more natural rather than having a limbo phase where the version is not ready, but already used.
I'm fine with that, I'm already working on applying the implementation to v1alpha2 and I'll do as @mjudeikis proposed.
@sttts @mjudeikis I created #3402 based on this PR with implementation for #3255. The PR is in the WIP state because I'm yet to add some more tests, but other than that, the implementation is complete and ready for review.
/retest
/retest
/lgtm /approve
Usage will follow in minutes from another PR. So this is no-op for now.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mjudeikis
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mjudeikis]
- ~~config/crds/OWNERS~~ [mjudeikis]
- ~~pkg/admission/OWNERS~~ [mjudeikis]
- ~~sdk/apis/OWNERS~~ [mjudeikis]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment