kcp icon indicating copy to clipboard operation
kcp copied to clipboard

Extend `apis.kcp.io/v1alpha2` with `APIBinding`

Open xmudrii opened this issue 7 months ago • 2 comments

Summary

This PR extends the apis.kcp.io/v1alpha2 with APIBindings and related types. This new version is a 1:1 copy of the current v1alpha1 API at the moment. The new v1alpha2 version will be changed after this PR is merged (to make this PR easier to review) as part of implementing #3255

All the code was updated to refer to v1alpha2.APIBindings.

https://github.com/kcp-dev/kcp/pull/3318 has been used as the inspiration for this PR.

What Type of PR Is This?

/kind feature

Related Issue(s)

None

Release Notes

Extended `apis.kcp.io/v1alpha2` with `APIBinding`

xmudrii avatar Apr 25 '25 17:04 xmudrii

Sgtm.

sttts avatar Apr 25 '25 22:04 sttts

While in general this looks good, the timing is questionable. Why don't we first get the API in place properly with the fields we want, and AFTER that do the "now everything will use it" PR ? Seems to be much more natural rather than having a limbo phase where the version is not ready, but already used.

sttts avatar Apr 27 '25 07:04 sttts

While in general this looks good, the timing is questionable. Why don't we first get the API in place properly with the fields we want, and AFTER that do the "now everything will use it" PR ? Seems to be much more natural rather than having a limbo phase where the version is not ready, but already used.

I think the bot works IF we can get the next PR "chained to this PR " and merge them together. Would want to see "implementation" first before start merging.

mjudeikis avatar Apr 27 '25 13:04 mjudeikis

While in general this looks good, the timing is questionable. Why don't we first get the API in place properly with the fields we want, and AFTER that do the "now everything will use it" PR ? Seems to be much more natural rather than having a limbo phase where the version is not ready, but already used.

I'm fine with that, I'm already working on applying the implementation to v1alpha2 and I'll do as @mjudeikis proposed.

xmudrii avatar May 06 '25 17:05 xmudrii

@sttts @mjudeikis I created #3402 based on this PR with implementation for #3255. The PR is in the WIP state because I'm yet to add some more tests, but other than that, the implementation is complete and ready for review.

xmudrii avatar May 09 '25 19:05 xmudrii

/retest

xmudrii avatar May 10 '25 07:05 xmudrii

/retest

xmudrii avatar May 16 '25 12:05 xmudrii

/lgtm /approve

Usage will follow in minutes from another PR. So this is no-op for now.

mjudeikis avatar May 19 '25 11:05 mjudeikis

LGTM label has been added.

Git tree hash: 21138c5cbb54299233d10c4861a15f6b48094db7

kcp-ci-bot avatar May 19 '25 11:05 kcp-ci-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kcp-ci-bot avatar May 19 '25 11:05 kcp-ci-bot