kcp-dev
feat(workspacetype): Add defaultAPIBinding lifecylce
Summary
Add a controller to automatically keep defaultAPIBindings defined in a workspacetype up to date in all workspaces that derive from it.
on-behalf-of: @eon-se [email protected]
What Type of PR Is This?
/kind feature /kind api-change
Related Issue(s)
- Fixes https://github.com/kcp-dev/kcp/issues/3248
- Replaces: https://github.com/kcp-dev/kcp/pull/3279
Release Notes
Add a controller to automatically keep defaultAPIBindings defined in a workspacetype up to date in all workspaces that derive from it.
Hi @MisterMX. Thanks for your PR.
I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
LGTM label has been added.
/approve
Given that https://github.com/kcp-dev/kcp/pull/3381#discussion_r2131842826 was a minor concern and I think it's fine, let's move this PR forward. It's been long in the making. Thank you so much for the contribution, @MisterMX.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: embik
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [embik]
- ~~config/crds/OWNERS~~ [embik]
- ~~sdk/apis/OWNERS~~ [embik]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added.