kcp
kcp copied to clipboard
kcp-dev
:sparkles: Promote mounts to spec
Summary
Related issue(s)
Fixes #
Release Notes
Deprecate experimental mount annotations
Promote mounts to workspace.spec.mount
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Have not read all the controller changes. Have you changed it to not have the shadow logical cluster? I.e. a mount is a mount, always. There is not this hybrid state depending on readiness.
Have not read all the controller changes. Have you changed it to not have the shadow logical cluster? I.e. a mount is a mount, always. There is not this hybrid state depending on readiness.
~~I think I did, need to check I pushed it out, but basically goal is "shallow workspace object" with no logicalcluster backing it~~.
Yes, basically "mounted" workspaces don't even create LogicalCluster object
Overall I think this looks good, do we want to merge this for 0.27 or keep it for the next development cycle? Because if we merge it for 0.27, I wanna make sure (with a follow-up ticket?) we document this. The current comments on the struct only really make sense if you already know how this works.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from embik. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Because if we merge it for 0.27, I wanna make sure (with a follow-up ticket?) we document this. The current comments on the struct only really make sense if you already know how this works.
At this point when it goes it goes :) no preference. Docs will be next ticket once this gets final rubber stamp for merging.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Need to rebase and see how we can add "References" into this. This was split and core got merged.
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Will close this as we have mvp merged. This adds type resolution but original requestor of this is not responsive on this.