kcp-dev
WIP: :bug: cache/replication: fix comparison whether update is needed by removing meta fields
Summary
NOT SURE THIS PR IS CORRECT: found https://github.com/kcp-dev/kcp/issues/2935 and https://github.com/kcp-dev/kubernetes/pull/132.
The comparison in the replication controller between cached and local object didn't filter generation and managedFields. This was leading to repeated replication.
Related issue(s)
Fixes #
Release Notes
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kcp-test-e2e-shared | 3fc6fdc4edab6e337d0817c68f3b4317f510d8f9 | link | true | /test pull-kcp-test-e2e-shared |
| pull-kcp-test-e2e-sharded | 3fc6fdc4edab6e337d0817c68f3b4317f510d8f9 | link | true | /test pull-kcp-test-e2e-sharded |
| pull-kcp-test-e2e | 3fc6fdc4edab6e337d0817c68f3b4317f510d8f9 | link | true | /test pull-kcp-test-e2e |
| pull-kcp-test-e2e-multiple-runs | 3fc6fdc4edab6e337d0817c68f3b4317f510d8f9 | link | true | /test pull-kcp-test-e2e-multiple-runs |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kcp-ci-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.