kcp icon indicating copy to clipboard operation
kcp copied to clipboard

:bug: tenancy/workspace-deletion: try harder with the admin client to delete the LogicalCluster

Open sttts opened this issue 10 months ago • 4 comments

Summary

The front-proxy might return errors when looking for the LogicalCluster on workspace deletion, especially when the LogicalCluster is already gone, and it returns a 403. This PR adds another attempt through the workspace admin client.

Related issue(s)

Fixes #

Release Notes

Make workspace deletion more reliable, trying harder to not leak `LogicalClusters`.

sttts avatar Apr 19 '24 19:04 sttts

@yastij: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kcp-ci-bot avatar Apr 23 '24 16:04 kcp-ci-bot

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kcp-ci-bot avatar Jul 22 '24 20:07 kcp-ci-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kcp-ci-bot avatar Aug 21 '24 20:08 kcp-ci-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kcp-ci-bot avatar Sep 20 '24 20:09 kcp-ci-bot

@kcp-ci-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kcp-ci-bot avatar Sep 20 '24 20:09 kcp-ci-bot

/reopen

sttts avatar Sep 22 '24 14:09 sttts

@sttts: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kcp-ci-bot avatar Sep 22 '24 14:09 kcp-ci-bot

/approve

sttts avatar Sep 22 '24 14:09 sttts

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kcp-ci-bot avatar Sep 22 '24 14:09 kcp-ci-bot