kcp
kcp copied to clipboard
kcp-dev
✨ Add OpenAPI Schema support to virtual workspace framework
Summary
Add OpenAPI Schema support to virtual workspace framework.
The implementation taps into the CreateServingInfo path to generate the spec and adds a handler to VW apiserver for handling the request and updating the OpenAPI v3 service caches.
TODO: OpenAPI v2 support and structuring the code for merge.
Related issue(s)
None
Release Notes
TODO: Before merge.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @palnabarun. Thanks for your PR.
I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Can you add an e2e test? Am interested to see the schema for exported and claimed resources (both APIResourceSchemas and native resources) of an APIExport.
Can you add an e2e test? Am interested to see the schema for exported and claimed resources (both APIResourceSchemas and native resources) of an APIExport.
@sttts Sure. I will explore the tests. Can you also add the ok-to-test label so that the usual tests run on the PR?
I think I might need this. I'm trying to implement a virtual workspace using the fixedgvs abstraction, but it keeps blowing up with "OpenAPIV3 config must not be nil".
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Hey @palnabarun, the 1.30 rebase is done now. Would you be interested in picking up this work again?