kcp
kcp copied to clipboard
kcp-dev
Generation number doesn't seem correctly set on cached builtin resources.
When completing the replication_test.go e2e cache test with replication scenarios of rbac resources (CR / CRB objects), the generation is not equal when comparing original and cached objects.
I added a TODO in the completed test: https://github.com/kcp-dev/kcp/blob/cf8a625b0266f761e70e0eb5dcde0817b6ac89e8/test/e2e/reconciler/cache/replication_test.go#L706-L716
Maybe the work done for CRD-backed resources in this PR should also be done for built-in resources that support replication ?
@p0lyn0mial do you happen to remember if this issue is still up to date and/or valid?
@p0lyn0mial do you happen to remember if this issue is still up to date and/or valid?
I think so, we wanted to fix it with https://github.com/kcp-dev/kubernetes/pull/132
and the test still (https://github.com/kcp-dev/kcp/blob/main/test/e2e/reconciler/cache/replication_test.go#L683) seems to be removing the "generation" field before comparison.
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale