:seedling: Update controllers to use committer package

[csams]

Many controllers use copy+paste abstraction for common controller functions, but they aren't all consistent. The committer package encapsulates type safe spec and status patching for arbitrary resources, so controllers can delegate to it for consistency in that phase of reconciliation.

This issue captures the work to update existing controllers to use the committer package.

• [ ] pkg/reconciler/apis/extraannotationsync/apibindingannotation_controller.go
• [x] pkg/reconciler/apis/permissionclaimlabel/permissionclaimlabel_controller.go
• [ ] pkg/reconciler/apis/permissionclaimlabel/permissionclaimlabel_resource_controller.go
• [ ] pkg/reconciler/core/logicalclusterdeletion/logicalcluster_deletion_controller.go
• [ ] pkg/reconciler/core/shard/shard_controller.go #2873
• [x] pkg/reconciler/scheduling/location/location_controller.go
• [x] pkg/reconciler/scheduling/placement/placement_controller.go
• [x] pkg/reconciler/tenancy/bootstrap/bootstrap_controller.go
• [ ] pkg/reconciler/tenancy/logicalcluster/logicalcluster_controller.go
• [ ] pkg/reconciler/tenancy/workspacetype/clusterworkspacetype_controller.go
• [ ] pkg/reconciler/workload/apiexportcreate/apiexportcreate_controller.go
• [ ] pkg/reconciler/workload/apiexport/workload_apiexport_controller.go
• [x] pkg/reconciler/workload/basecontroller/controller.go #2691
• [ ] pkg/reconciler/workload/namespace/namespace_controller.go #2874
• [ ] pkg/reconciler/workload/synctarget/synctarget_controller.go
• [ ] pkg/syncer/resourcesync/controller.go
• [ ] pkg/syncer/spec/spec_process.go
• [ ] pkg/syncer/status/status_process.go
• [ ] pkg/virtual/apiexport/controllers/apireconciler/apiexport_apireconciler_controller.go
• [ ] pkg/virtual/syncer/controllers/apireconciler/syncer_apireconciler_controller.go

[kcp-ci-bot]

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[kcp-ci-bot]

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

[kcp-ci-bot]

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

[kcp-ci-bot]

@kcp-ci-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.