kcp icon indicating copy to clipboard operation
kcp copied to clipboard

workspaces VW: remove the need of a SAR against CWT

Open davidfestal opened this issue 2 years ago • 3 comments

We should completely remove the need of issuing a SAR against ClusterWorkspaceType in the Create implementation of the workspaces virtual workspace.

This SAR simply forces the VW to set a static default CWT reference, which should be done by the admission controller.

But removing this SAR requires updating the CWT admission controllers to take in account the owner annotation set by the VW, when it is there (and user is the system:apiserver).

davidfestal avatar Jun 30 '22 12:06 davidfestal

This a followup of https://github.com/kcp-dev/kcp/pull/1414

davidfestal avatar Jun 30 '22 13:06 davidfestal

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kcp-ci-bot avatar Apr 13 '24 20:04 kcp-ci-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kcp-ci-bot avatar May 13 '24 20:05 kcp-ci-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kcp-ci-bot avatar Jun 12 '24 20:06 kcp-ci-bot

@kcp-ci-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kcp-ci-bot avatar Jun 12 '24 20:06 kcp-ci-bot