kcp-dev
virtualworkspaces: discovery puts logical cluster name into storage version hash
Right now we're adding the logical cluster name to the storage version hash:
https://github.com/kcp-dev/kubernetes/blob/d2ffaa089de03af449da7c02170b54aa6df1bccb/staging/src/k8s.io/apiserver/pkg/endpoints/discovery/storageversionhash.go#L28
https://github.com/kcp-dev/kcp/blob/8d8a3ab50622bee6aada2de7567c48da816602a4/pkg/virtual/framework/dynamic/apiserver/discovery.go#L113
The KEP for this seems to suggest only the storage version migrator uses this field:
https://github.com/kubernetes/enhancements/blob/6a4aadc1a4aa6cbf931fdb91f52f6ff72f436a1d/keps/sig-api-machinery/2342-exposing-hashed-storage-versions-via-the-discovery-API/README.md
So it is functionally useless for us right now. In any case, it does not seem correct to add the logical cluster to the GVK in order to determine the storage version hash, especially given how we are changing the storage prefix. We should figure this out correctly at some point.
/cc @ncdc @sttts @davidfestal
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kcp-ci-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.