qart.js icon indicating copy to clipboard operation
qart.js copied to clipboard

Published 20 hours ago • verified publisher icon kciter

use `qrcode-generator` as package dependency?

Open sabrinaluo opened this issue 5 years ago • 1 comments

Hello, thank you for the amazing qart.

Wondering if it's possible to use https://www.npmjs.com/package/qrcode-generator as dependency rather than including qrcode.js in the bundle? or maybe expose qrcode API ?

The situation I encountered is to need both API of qart and qrcode, since qart didn't expose the qrcode API, will need to install the origin qrcode-generator. This makes the bundle size bigger than it should. :)

sabrinaluo avatar Jul 13 '18 14:07 sabrinaluo

@sabrinaluo Hi, please welcome pull request. @kciter what u think(do we have any changes in local version) ?

misteral avatar Jul 15 '18 14:07 misteral