node-cas icon indicating copy to clipboard operation
node-cas copied to clipboard

Don't lowercasify CAS attribute names

Open jalfonso opened this issue 9 years ago • 2 comments

This library converts CAS attribute names to lowercase (example).

This is not prescribed by the CAS protocol specification. Note that the CAS protocol documentation even includes an example of a validation response which includes mixed-case attribute names (See Appendix A, "Example response with custom attribute")

This may have implications for the current users of this module. Perhaps a flag could be added to allow case-preserved attributes?

jalfonso avatar Sep 28 '16 13:09 jalfonso

Oop, there's even mixed case in the example response in the code comments.

I can work on a pull request if it would help

jalfonso avatar Sep 28 '16 13:09 jalfonso

https://github.com/kcbanner/node-cas/pull/9/commits/bc1609f119a042bc5c3650c60a48daae3b8682cd fixes this

nitinhayaran avatar Mar 09 '17 13:03 nitinhayaran