openal-soft icon indicating copy to clipboard operation
openal-soft copied to clipboard

Published 20 hours ago • verified publisher icon kcat

SET_TARGET_PROPERTIES: Incorrect Arguments

Open marauder2k7 opened this issue 2 years ago • 2 comments

https://github.com/kcat/openal-soft/blob/0891f1342d3d4741ca38f3c1e7437aeb7e0c0d01/CMakeLists.txt#L1391

These variables in the properties were failing for me building, wrapping them in quotes fixed the issue though

error: set_target_properties incorrect arguments

Wrapping them in quotes makes sure they get assigned even if the var is empty

marauder2k7 avatar Aug 28 '22 10:08 marauder2k7

Does it work now with commit 6e94db24015ca9aa7a76e7c3340143e4c3a66806?

kcat avatar Aug 28 '22 10:08 kcat

Sorry you need to wrap ${BUNDLE_VERSION} aswell with quotes, i made those changes and it works for me yeah :)

for us we also added efx-presets to the target set(TARGET_PUBLIC_HEADERS include/AL/al.h include/AL/alc.h include/AL/alext.h include/AL/efx.h include/AL/efx-presets.h)

marauder2k7 avatar Aug 28 '22 11:08 marauder2k7

Fixed with commit 057a350c1e15906d12559acb56115fbef2d9a3bf.

kcat avatar Sep 22 '22 21:09 kcat