dsoal icon indicating copy to clipboard operation
dsoal copied to clipboard

Published 20 hours ago • verified publisher icon kcat

Disable all 3D processing in DS3DMODE_DISABLE mode

Open rafalh opened this issue 5 years ago • 2 comments

This change allows using SetPan API for buffers with DSBCAPS_CTRL3D flag when DS3DMODE_DISABLE mode is active. Fixes panning in Red Faction if EAX is enabled (see #18).

rafalh avatar Oct 04 '20 11:10 rafalh

Is there anything I could improve in my PR @kcat ?

rafalh avatar Jan 10 '22 00:01 rafalh

Is there anything I could improve in my PR @kcat ?

As already mentioned, the way you're replacing DSBCAPS_CTRL3D checks with DS3DMODE_DISABLE will break non-3D buffer panning, as well as effects for buffers with DS3DMODE_DISABLE set.

kcat avatar Jan 10 '22 01:01 kcat