Calvin Kim

Results 49 comments of Calvin Kim

ACK 14a164083b168d2c1c662e16d9b2157cfa042b72 Looks like a simple cleanup.

> For this purpose, wouldn't it make sense to use the last-seen tip height rather than a UNIX timestamp? Height + Hash would be better. I'm not too familiar with...

> > Height + Hash would be better. I'm not too familiar with the bdk internals so I suggested unix time since you can immediately calculate that and store it...

I guess I should add that I don't think the nodes returned by "seed.bitcoinstats.com" are good. My assumptions is that it's just caching all the nodes it's previously seen and...

Just checking in on this. Seemingly nothing's been changed since posting about this back in April

Is this ready for review?

Most of the code is the same right? It's a bit hard to review since there's removed lines that turn this into a decently sized change. Could you add those...

> @adiabat @kcalvinalvin, this PR can be merged. 😅 I don't have merge access to this repo. @adiabat?

Sounds good but that does require varint encoding and unfortunately we can't import from utcd/btcd because that results in import cycles. Two ways of going about this: 1: Move package...