svelte-french-toast icon indicating copy to clipboard operation
svelte-french-toast copied to clipboard

dark mode button on demo website is not working

Open sina-salahshour opened this issue 11 months ago • 4 comments

https://svelte-french-toast.vercel.app/

examples section.

Dark mode button opens a light toast.

sina-salahshour avatar Mar 08 '24 20:03 sina-salahshour

https://github.com/kbrgl/svelte-french-toast/blob/2dd9abc205fe7e161802593e03b680350b237184/src/lib/components/ToastWrapper.svelte#L47-L53

It appears that the assignment of the background attribute is missing. @kbrgl

kworkbee avatar Mar 13 '24 00:03 kworkbee

https://github.com/kbrgl/svelte-french-toast/pull/48 According to this PR, it seems that the props property should be used, but it seems that it hasn't been released yet?

kworkbee avatar Mar 13 '24 00:03 kworkbee

#48 According to this PR, it seems that the props property should be used, but it seems that it hasn't been released yet?

I have no clue but can it be because the package version hasn't changed since? maybe vercel cached the package on last version change (from 1.1 to 1.2) and used that on other deploys... because i tested locally and dark theme styles works fine.

sina-salahshour avatar Mar 13 '24 01:03 sina-salahshour

I checked again and it's working fine 😅

toast("TEST", {
          icon: "👏",
          style: "color: #fff; background-color: #333; font-size: 20px;",
        });

kworkbee avatar Mar 13 '24 01:03 kworkbee