svelte-french-toast icon indicating copy to clipboard operation
svelte-french-toast copied to clipboard

Published 20 hours ago • verified publisher icon kbrgl

improvement to toast.promise

Open winston0410 opened this issue 2 years ago • 2 comments

This PR aims to solve the following issues for toast.promise

  • support dynamic toast message based on promise's result, fallback to the static message provided initially

  • handle edge case where toast.loading has been set with {duration: Infinity}, and toast.success and toast.error will not go away as well

The only thing that I am not sure is why is resolveValue function used there previously.

winston0410 avatar Feb 08 '23 21:02 winston0410

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
svelte-french-toast ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 9:38PM (UTC)

vercel[bot] avatar Feb 08 '23 21:02 vercel[bot]

@kbrgl what do you think about this?

winston0410 avatar Feb 08 '23 21:02 winston0410