fritzconnection icon indicating copy to clipboard operation
fritzconnection copied to clipboard

fritzcallforwarding

Open jmtatsch opened this issue 5 years ago • 3 comments

Hi Klaus,

was the fritzcallforwarding module i contributed somehow removed on purpose or did it get lost in the translation somewhere?

jmtatsch avatar Feb 27 '20 10:02 jmtatsch

Hi Julian,

not all library modules have been translated at the first attempt. Especial fritzcallforwarding needs some work (like fritzphonebook), because the lxml-dependency has been removed (making it much more easier to install fritzconnection on some platforms). So your module is not forgotten and will come back. Thank you very much for the contribution of fritzcallforwarding.

kbr avatar Feb 27 '20 19:02 kbr

Hi Klaus,

that is great to hear. Maybe I can help. So it is just the lxml that needs to be replaced or other stuff as well?

jmtatsch avatar Feb 28 '20 15:02 jmtatsch

Hi Julian,

if you have some spare time and like to help out, that would be very appreciated. Rewriting fritzcallforwarding is a bit challenging because there is an action_call that returns a url to retrieve the real data as xml. Parsing the xml data can be done by using the new @processor class-decorator from fritzconnection.core.processor. That's also the preferred way to do it. The module fritzphonebook can be used as an example. If you have any questions, please don't hesitate to ask.

kbr avatar Feb 29 '20 15:02 kbr