Kevin Bond

Results 560 comments of Kevin Bond

> However, in cases like mine, there's a problem with resulting HTML size and memory/CPU needed to process and render it. Got it, that makes sens. > we should find...

I'm not a huge fan of `signAndWrap()` and the `SignedUri` VO. I'd be ok dropping these and just keeping `verify()` + named exceptions.

I've updated this PR to just add `SignedUri::verify()`.

> litte bit curious why are we not throwing a HttpException here? The purpose of this feature is to distinguish between the different reasons for a signed url validation error....

Currently, this PR only adds a failing test demonstrating the problem reported in #1839. I could use some help to fix!

That's weird - what about the ago messages, are they shown correctly? Any details in the web debug toolbar's translation panel?

Hmm, ok, I was a bit perturbed that knp time bundle requires translation. I might look into removing this requirement. In the meantime, you should be able to remove knp...

Understand now - #150 should fix.

I see, so you had Symfony/translator installed but actively disabled?