Kevin Bond

Results 420 comments of Kevin Bond

I can definitely see the use case for asserting stamps you define are added to your messages but as for wiring up your production transports (even the serializer imo) should...

Question, is your `ExternalJsonMessageSerializer` equipped to "unserialize" the message or is this done in a completely separate app? Basically, is [this](https://github.com/zenstruck/messenger-test/blob/1.x/src/Transport/TestTransport.php#L181) causing a problem?

> In that case for me, with your lib we can perform integration tests but not really functional test. That's a good way to put it.

So, I'm thinking the stamp assertions are useful and well within the scope of this library. Would that be helpful for you?

> Yes that would still be helpful Ok, I can work on this feature - it's related to #3. > and the serializedMessage too because your lib use the same...

Hi @clemcoder! I'm wondering if it is there but during serialization, it is lost from `getHtmlBody()`. What does the following output? ```php dd($email->getBody()->toString()); ``` Do you see the html? >...

Oh! You'll need to process the queue before you can see the html. I think the following will work: ```php $asyncMessengerTransport = $this->messenger('async'); $asyncMessengerTransport->queue()->assertCount(1); $asyncMessengerTransport->process(); $firstMessage = $asyncMessengerTransport->acknowledged()->first()->getMessage(); $email =...

Hmm ok, I guess processing the email doesn't manipulate the message. At the end of the day I believe this makes sense and is expected. I guess you can't use...

Hey @myselfhimself! Interesting. This method is sort of intended as a quick and dirty solution. We can't change it's behaviour now as it would be a BC break. You could...