StatePrinter icon indicating copy to clipboard operation
StatePrinter copied to clipboard

Published 20 hours ago • verified publisher icon kbilsted

Strict C# formatting

Open mikechamberlain opened this issue 6 years ago • 2 comments

mikechamberlain avatar Jun 24 '18 17:06 mikechamberlain

Hi Mike.

Thanks for the PR :-)

Is there a test that shows the new behaviour the diff in the commit seems not to convey the new functionality?

Should there be a strict option in the c# formatter instead? what are the design decisions for a separate formatter?

kbilsted avatar Jan 09 '19 15:01 kbilsted

Hi Kasper,

Not quite sure what you are asking as there are tests included in the PR. For context, I referenced this PR from the original issue #54. Though I got close, I never got to this work 100%, as you can see from the failing test.

My changes were good enough for my needs (I just fixed the invalid output by hand). Unfortunately I don't have time to look at this right now. If you think strict C# output is useful feature then hopefully you or someone else will be able to make it work. I think it's pretty close right now.

mikechamberlain avatar Jan 13 '19 04:01 mikechamberlain