sfdmap icon indicating copy to clipboard operation
sfdmap copied to clipboard

Swap deprecated np.int to int

Open robertdstein opened this issue 2 years ago • 3 comments

Since numpy v1.20, the use of aliases such as np.int have been deprecated (see e.g https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations). The recommended solution is to instead useint, which is equivalent. This PR replaces for four instances of np.int in sfdmap.py with int.

When I run the unit tests, I would previously get 38 warnings with numpy v1.22, but now get none.

robertdstein avatar Jun 17 '22 18:06 robertdstein

@kbarbary I would really appreciate if this pull request is accepted!

temuller avatar Aug 16 '22 11:08 temuller

@kbarbary could you please check this PR?

temuller avatar Feb 15 '23 13:02 temuller

Note that a fork is being maintained at https://github.com/AmpelAstro/sfdmap2

I have mentioned this in #2.

mlincett avatar May 10 '23 16:05 mlincett