Konstantin Baierer

Results 301 comments of Konstantin Baierer

> Makefile could check whether that virtual environment was active outside of make and skip the removal then. Sounds reasonable :+1: @bertsky any consequences we're not seeing?

> + if ! command -v activate; then $(RM) -r $(VIRTUAL_ENV; fi I don't think `activate` will be detected as a command because while in $PATH if $VIRTUAL_ENV is activated...

> I wonder whether we really need export PIP ?= pip3 and would prefer to replace $(PIP) by a simple pip We don't need it any more, we did need...

We should probably add a `clean` target to ocrd_anybaseocr and delegate to it on `make clean` in ocrd_all, like we do for `deps-ubuntu`. What do you think @stweil @bertsky

> So I think I'll just upload a pkg for it myself. https://pypi.org/project/pix2pixhd/ :tada:

> (@kba if we can agree on this plan then I recommend transferring the issue to ocrd_anybaseocr, which I have no permissions for. I could but you solved everything AFAICS....

Unfortunately, we have now a situation where both tensorflow (tf2) and tensorflow-gpu (tf1) can [be installed side-by-side](https://github.com/OCR-D/ocrd_all/pull/115), so scripts won't fail at startup anymore but when doing the customary `import...

From the direct requirements: | project | tf1 | tf2 | | --- | --- | --- | | cor-asv-ann | ✗ | | | ocrd_anybaseocr | | ✗ |...

> Why shouldn't we allow venvs inside Docker images? I was not clear: That can also be done with a mechanism like the one you describe. No reason not to...

See https://github.com/OCR-D/ocrd_calamari/issues/68 for the discussion upstream.