Konstantin Baierer
Konstantin Baierer
That's a great proposal and would also be an option to keep `@imageFilename` and `@xlink:href` in check. The idea behind the `local_filename` property was much the same: To have a...
Yes, the [ZVDD guidelines](https://www.zvdd.de/fileadmin/AGSDD-Redaktion/METS_Anwendungsprofil_2.1.pdf) are pretty restrictive. FLocat isn't repeatable. But it also says `@xlink:href` must be a URL which I tried to defend for the longest time but we're...
We could also implement the local_filename stuff as additional FLocat as you propose and have a processor that strips the METS down to ZVDD requirements.
@kba Would it be okay to you if I do pytest refactorings of test/cli/test_workspace within the scope of this PR? Sure, thank you > Oh no, I've just learned that...
Also, why have separate `_fileGrp_cache` and `_file_cache` - doesn't the latter also contain the fileGrp info in a fast-to-access way? What would be more beneficial would be caching the `pageId`...
> The `_fileGrp_cache` holds a reference to the fileGrp element itself aka the memory location. The `_file_cache` holds just a string of the fileGrp. I get that, but the main/only...
> we decided to only accept nextflow scripts so a converter is not needed This was about an intermediate format between the purely sequential `ocrd process` calls and the NF...
> But we probably also have to enforce this outside of `make_file_id`, probably in `Workspace.add_file`: When adding a PAGE-XML file for a pageId that already exists in that fileGrp, >...
> You said re-review, which I did, but now you already merged without my suggestions… I'll amend.
> > You said re-review, which I did, but now you already merged without my suggestions… > > I'll amend. Done in https://github.com/OCR-D/core/tree/861-re-review. Many thanks for the documentation fixes.